Follow

I opened a pull-request on GitHub and got minor comments from reviewers. After addressing them, should I amend the commit and then 'git push --force', or create a new commit and push? In the latter case, what do I write in the commit message? And is there a way to squash these review commits when the change is merged?

I feel stupid for having to ask, but I haven't had a chance to contribute to opensource projects while being a sarariman 😅

· · Web · 1 · 1 · 0

@codewiz Put logically separate things in separate commits and use fixup & rebase to fix issues in them.

See also: git-rebase.io/#fixup

Sign in to participate in the conversation
Mastodon

The social network of the future: No ads, no corporate surveillance, ethical design, and decentralization! Own your data with Mastodon!